Uploaded image for project: 'Schematron Validator'
  1. Schematron Validator
  2. SCHVAL-166

Improve code and business location through the code for better unit-test coverage

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.4.0
    • Labels:
      None
    • Account:
      Maintenance 2018 (MAINTENANCE2018)

      Description

      The goal is to have a better repartition and distributivity of responsibilities through the code to be able to have lot more unit-test.

      Split and or organize the code :
      0. Model with entities

      1. DAOs responsibles for db and file access that can be mocked for unit tests. Any file/db access is strongly discourage at other places.

      2. An API and its implementation able to manipulate entities (no db/file access) to preform validation and sch compilation, duplication... (all business features). Those will then be covered by unit-tests.

      3. The WS layer that is responsible of converting input/output type and invoke the API and/or the DAOs. (if 1. and 2. are well done, it should be possible to have unit tests for the WS API and conversion step)

      4. GUI beans only responsible of GUI action and page state holder, that will invoke the API and/or the DAOs.

      Pay attention to dependency cycles in this kind of architecture

        Attachments

          Activity

            People

            • Assignee:
              hra Hilary Rama
              Reporter:
              ceoche Cédric EOCHE-DUVAL
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 2 days Original Estimate - 2 days
                2d
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 weeks, 30 minutes
                2w 30m

                  Potential Duplicates