Details
-
Type: Bug
-
Status: Resolved
-
Priority: High
-
Resolution: Fixed
-
Affects Version/s: 2.1.0
-
Fix Version/s: 2.2.0
-
Component/s: SVS Repository
-
Labels:None
-
Account:Sequoia 2019 - SOW11 (SEQUOIA_SOW11)
Description
The administrator has the ability to create/update value sets by importing RetrieveValueSetResponse XML file into the tool, the observed current behaviour is the following:
Case 1: ValueSet/@id attribute does not match any OID of value set in the database ==> A new value set is created
Case 2: ValueSet/@id attribute matches the OID of a value set in the database but the conceptList/@lang attribute does not match any of the languages used by the existing conceptList for this value set ==> concept list is added BUT other attributes of the value set (like the version) is not updated
Case 3: ValueSet/@id attribute matches as well as ConceptList/@lang ==> no operation performed
SUGGESTED SOLUTION
Case 1 is OK
Case 2 is OK but we need to allow the administrator to say whether or not he wants the other attributes of the value sets to be updated (checkbox: update attributes of value set using new values ?)
Case 3 : same checkbox as for Case 2 + delete the corresponding concept list and replace it by the new one coming from the uploaded file
NOTE: by definition, two concept lists from a given value set shall have exactly the same number of entries and the code/@code value shall match but this is not currently checked, we trust the administrator that he performs the checks in advance. Do we need to automate it ?
In order to track and validate the changes, I would like to see a screen simular to what we have in Assertion Manager when we compute the coverage. We need three columns new concepts, updated concepts, deleted concepts. See attached picture
Case 1: ValueSet/@id attribute does not match any OID of value set in the database ==> A new value set is created
Case 2: ValueSet/@id attribute matches the OID of a value set in the database but the conceptList/@lang attribute does not match any of the languages used by the existing conceptList for this value set ==> concept list is added BUT other attributes of the value set (like the version) is not updated
Case 3: ValueSet/@id attribute matches as well as ConceptList/@lang ==> no operation performed
SUGGESTED SOLUTION
Case 1 is OK
Case 2 is OK but we need to allow the administrator to say whether or not he wants the other attributes of the value sets to be updated (checkbox: update attributes of value set using new values ?)
Case 3 : same checkbox as for Case 2 + delete the corresponding concept list and replace it by the new one coming from the uploaded file
NOTE: by definition, two concept lists from a given value set shall have exactly the same number of entries and the code/@code value shall match but this is not currently checked, we trust the administrator that he performs the checks in advance. Do we need to automate it ?
In order to track and validate the changes, I would like to see a screen simular to what we have in Assertion Manager when we compute the coverage. We need three columns new concepts, updated concepts, deleted concepts. See attached picture